Skip to content

fix(FR-2844): keep 'Revision' untranslated in zh-CN/zh-TW NoCurrentRevisionDeployed alert#7306

Merged
yomybaby merged 1 commit into
mainfrom
05-08-fix_fr-2844_keep_revision_untranslated_in_zh-cn_zh-tw_nocurrentrevisiondeployed_alert
May 8, 2026
Merged

fix(FR-2844): keep 'Revision' untranslated in zh-CN/zh-TW NoCurrentRevisionDeployed alert#7306
yomybaby merged 1 commit into
mainfrom
05-08-fix_fr-2844_keep_revision_untranslated_in_zh-cn_zh-tw_nocurrentrevisiondeployed_alert

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 8, 2026

Resolves #7305 (FR-2844)

Summary

  • Address Copilot review feedback on feat(FR-2843): title-only deployment alerts and warning type for NoRevision #7304: in zh-CN and zh-TW, every other deployment-revision string in this feature ('AddRevision', 'CurrentRevision', 'RevisionHistory') keeps the English 'Revision' term, but the new deployment.NoCurrentRevisionDeployed alert text was translated to '修订版' / '修訂版'. That made the alert read inconsistently with the buttons and tab labels users see on the same screen.
  • Replace the localized term with 'Revision' so the alert text now reads consistently with the surrounding UI.

Test plan

  • Switch language to zh-CN; on a deployment with no revision, verify the alert reads '尚未部署任何 Revision — 添加 Revision 以激活此服务。'
  • Switch language to zh-TW; verify the alert reads '尚未部署任何 Revision — 新增 Revision 以啟動此服務。'
  • Confirm the wording matches the 'AddRevision' / 'CurrentRevision' / 'RevisionHistory' labels on the same page.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:XS ~10 LoC labels May 8, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented May 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review May 8, 2026 04:52
Copilot AI review requested due to automatic review settings May 8, 2026 04:52
@yomybaby yomybaby merged commit 8fba890 into main May 8, 2026
11 checks passed
@yomybaby yomybaby deleted the 05-08-fix_fr-2844_keep_revision_untranslated_in_zh-cn_zh-tw_nocurrentrevisiondeployed_alert branch May 8, 2026 04:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Chinese (Simplified/Traditional) i18n strings for the deployment “No current revision deployed” alert to keep the technical term “Revision” untranslated, aligning with adjacent deployment terminology in the UI.

Changes:

  • zh-CN: Replace localized “修订版” with “Revision” in deployment.NoCurrentRevisionDeployed.
  • zh-TW: Replace localized “修訂版” with “Revision” in deployment.NoCurrentRevisionDeployed.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
resources/i18n/zh-CN.json Updates the NoCurrentRevisionDeployed translation to keep “Revision” in English.
resources/i18n/zh-TW.json Updates the NoCurrentRevisionDeployed translation to keep “Revision” in English.

Comment thread resources/i18n/zh-CN.json
Comment on lines 959 to 962
"NewRevisionWillBeCreated": "将创建新的 Revision。之前的 Revision 将被保留。",
"NewRevisionWillBeCreatedConfirm": "保存将创建新的 Revision。是否继续?",
"NoCurrentRevisionDeployed": "尚未部署任何修订版 — 添加修订版以激活此服务。",
"NoCurrentRevisionDeployed": "尚未部署任何 Revision — 添加 Revision 以激活此服务。",
"NoDeployments": "未找到部署。",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align zh-CN/zh-TW Revision terminology in NoCurrentRevisionDeployed alert

2 participants